security: high-severity fixes (api throttle, fillable, idor, path, rel)

- Add 60 req/min throttle to the public API group and a stricter 10 req/min
  throttle to POST /highscores.
- Replace mass-assigned $guarded=[] with explicit $fillable on User, Meetup,
  Course, Lecturer, and SelfHostedService. created_by stays out of the
  whitelist; the existing creating() hooks continue to populate it.
- Require authenticated user on Api/MeetupController::index instead of
  trusting the user_id query parameter (IDOR).
- Constrain the /img and /img-public route paths to a safe character set
  and reject any path containing ".." in ImageController.
- Add rel="noopener noreferrer" to every target="_blank" link on the meetup
  and course landing pages.
This commit is contained in:
Claude
2026-05-03 12:55:09 +00:00
parent 90835f8b1f
commit 9b81f6cd92
11 changed files with 100 additions and 35 deletions
+6 -4
View File
@@ -20,11 +20,13 @@ class Course extends Model implements HasMedia
use InteractsWithMedia;
/**
* The attributes that aren't mass assignable.
*
* @var array
* @var array<int, string>
*/
protected $guarded = [];
protected $fillable = [
'name',
'lecturer_id',
'description',
];
/**
* The attributes that should be cast to native types.
+17 -4
View File
@@ -22,11 +22,24 @@ class Lecturer extends Model implements HasMedia
use InteractsWithMedia;
/**
* The attributes that aren't mass assignable.
*
* @var array
* @var array<int, string>
*/
protected $guarded = [];
protected $fillable = [
'name',
'slug',
'subtitle',
'intro',
'description',
'active',
'website',
'twitter_username',
'nostr',
'lightning_address',
'lnurl',
'node_id',
'paynym',
'team_id',
];
/**
* The attributes that should be cast to native types.
+18 -4
View File
@@ -23,11 +23,25 @@ class Meetup extends Model implements HasMedia
use InteractsWithMedia;
/**
* The attributes that aren't mass assignable.
*
* @var array
* @var array<int, string>
*/
protected $guarded = [];
protected $fillable = [
'name',
'slug',
'city_id',
'intro',
'telegram_link',
'webpage',
'twitter_username',
'matrix_group',
'nostr',
'nostr_status',
'simplex',
'signal',
'community',
'github_data',
'visible_on_map',
];
/**
* The attributes that should be cast to native types.
+16 -1
View File
@@ -22,7 +22,22 @@ class SelfHostedService extends Model implements HasMedia
use HasTags;
use InteractsWithMedia;
protected $guarded = [];
/**
* @var array<int, string>
*/
protected $fillable = [
'name',
'slug',
'type',
'intro',
'url_clearnet',
'url_onion',
'url_i2p',
'url_pkdns',
'ip',
'contact',
'anon',
];
protected $casts = [
'id' => 'integer',
+22 -1
View File
@@ -24,7 +24,28 @@ class User extends Authenticatable implements CipherSweetEncrypted
use Notifiable;
use UsesCipherSweet;
protected $guarded = [];
protected $fillable = [
'name',
'email',
'password',
'email_verified_at',
'remember_token',
'profile_photo_path',
'public_key',
'is_lecturer',
'is_leader',
'current_team_id',
'current_language',
'timezone',
'lightning_address',
'lnurl',
'node_id',
'paynym',
'nostr',
'lnbits',
'change',
'change_time',
];
/**
* The attributes that should be hidden for serialization.