mirror of
https://github.com/HolgerHatGarKeineNode/einundzwanzig-app.git
synced 2026-06-11 02:50:29 +00:00
✨ Add ResolvesEntities concern for name-based ID resolution
- 🤖 Introduced `ResolvesEntities` trait to simplify entity resolution by name or ID across MCP tools. - 📚 Updated tools (Meetups, Cities, Venues, Courses, Lecturers) to use the concern for resolving related entities (e.g., courses, venues, lecturers). - 🎯 Enhanced tool descriptions and schemas for better name-based parameter handling with fallback support for IDs. - ✅ Added dedicated feature tests for name resolution logic, partial matches, and error handling scenarios.
This commit is contained in:
@@ -4,6 +4,8 @@ namespace App\Mcp\Tools\Meetup;
|
||||
|
||||
use App\Http\Requests\Api\UpdateMeetupRequest;
|
||||
use App\Http\Resources\MeetupResource;
|
||||
use App\Mcp\Tools\Concerns\ResolvesEntities;
|
||||
use App\Models\City;
|
||||
use App\Models\Meetup;
|
||||
use Illuminate\Contracts\JsonSchema\JsonSchema;
|
||||
use Illuminate\JsonSchema\Types\Type;
|
||||
@@ -13,15 +15,17 @@ use Laravel\Mcp\Response;
|
||||
use Laravel\Mcp\Server\Attributes\Description;
|
||||
use Laravel\Mcp\Server\Tool;
|
||||
|
||||
#[Description('Aktualisiert ein bestehendes Meetup. Nur der Ersteller oder ein Super-Admin darf es ändern.')]
|
||||
#[Description('Aktualisiert eines deiner Meetups (per Name angegeben). Nur der Ersteller oder ein Super-Admin darf es ändern.')]
|
||||
class UpdateMeetupTool extends Tool
|
||||
{
|
||||
use ResolvesEntities;
|
||||
|
||||
public function handle(Request $request): Response
|
||||
{
|
||||
$meetup = Meetup::find($request->get('id'));
|
||||
$meetup = $this->resolveOwnedByName($request, Meetup::class, 'Meetups', 'meetup');
|
||||
|
||||
if (! $meetup) {
|
||||
return Response::error('Meetup nicht gefunden.');
|
||||
if ($meetup instanceof Response) {
|
||||
return $meetup;
|
||||
}
|
||||
|
||||
$user = $request->user();
|
||||
@@ -30,6 +34,10 @@ class UpdateMeetupTool extends Tool
|
||||
return Response::error('Nur der Ersteller oder ein Super-Admin darf dieses Meetup ändern.');
|
||||
}
|
||||
|
||||
if ($error = $this->mergeForeignKey($request, 'city', 'city_id', City::query(), 'Stadt', false)) {
|
||||
return $error;
|
||||
}
|
||||
|
||||
$validated = $request->validate((new UpdateMeetupRequest)->rules());
|
||||
|
||||
$meetup->update($validated);
|
||||
@@ -43,9 +51,11 @@ class UpdateMeetupTool extends Tool
|
||||
public function schema(JsonSchema $schema): array
|
||||
{
|
||||
return [
|
||||
'id' => $schema->integer()->description('ID des zu aktualisierenden Meetups.')->required(),
|
||||
'name' => $schema->string()->description('Name des Meetups.'),
|
||||
'city_id' => $schema->integer()->description('ID der zugehörigen Stadt.'),
|
||||
'meetup' => $schema->string()->description('Name des zu ändernden Meetups (aus deinen Meetups, siehe list-my-meetups).'),
|
||||
'id' => $schema->integer()->description('Optional: ID des Meetups, falls bereits bekannt (Alternative zu "meetup").'),
|
||||
'name' => $schema->string()->description('Neuer Name des Meetups.'),
|
||||
'city' => $schema->string()->description('Name der zugehörigen Stadt (wird automatisch aufgelöst).'),
|
||||
'city_id' => $schema->integer()->description('Optional: ID der Stadt (Alternative zu "city").'),
|
||||
'intro' => $schema->string()->description('Einleitungstext.'),
|
||||
'telegram_link' => $schema->string()->description('Telegram-Gruppen-URL.'),
|
||||
'webpage' => $schema->string()->description('Webseiten-URL.'),
|
||||
|
||||
Reference in New Issue
Block a user