mirror of
https://github.com/HolgerHatGarKeineNode/einundzwanzig-app.git
synced 2026-05-20 20:55:36 +00:00
🐛 **Handle stale Livewire asset exceptions gracefully**
- ✅ Added detection logic for stale Livewire asset patterns to avoid 500 errors. - 🛠️ Updated exception handling to return 404 for stale asset requests. - 🔇 Prevented logging of stale asset exceptions to avoid unnecessary noise. - ✅ Added tests to verify 404 responses and absence of log entries for stale asset scenarios.
This commit is contained in:
+22
-6
@@ -25,12 +25,14 @@ return Application::configure(basePath: dirname(__DIR__))
|
||||
]);
|
||||
})
|
||||
->withExceptions(function (Exceptions $exceptions) {
|
||||
$exceptions->render(function (Throwable $e, Request $request) {
|
||||
if (! preg_match('#^livewire-[a-f0-9]+/(?:css|js)/#', $request->path())) {
|
||||
return null;
|
||||
$isStaleLivewireAsset = function (Throwable $e, ?Request $request): bool {
|
||||
if (! $request instanceof Request) {
|
||||
return false;
|
||||
}
|
||||
|
||||
$message = $e->getMessage();
|
||||
if (! preg_match('#^livewire-[a-f0-9]+/(?:css|js)/#', $request->path())) {
|
||||
return false;
|
||||
}
|
||||
|
||||
$stalePatterns = [
|
||||
'does not have a style source',
|
||||
@@ -42,11 +44,25 @@ return Application::configure(basePath: dirname(__DIR__))
|
||||
];
|
||||
|
||||
foreach ($stalePatterns as $pattern) {
|
||||
if (str_contains($message, $pattern)) {
|
||||
return response('', 404);
|
||||
if (str_contains($e->getMessage(), $pattern)) {
|
||||
return true;
|
||||
}
|
||||
}
|
||||
|
||||
return false;
|
||||
};
|
||||
|
||||
$exceptions->report(function (Throwable $e) use ($isStaleLivewireAsset) {
|
||||
if ($isStaleLivewireAsset($e, request())) {
|
||||
return false;
|
||||
}
|
||||
});
|
||||
|
||||
$exceptions->render(function (Throwable $e, Request $request) use ($isStaleLivewireAsset) {
|
||||
if ($isStaleLivewireAsset($e, $request)) {
|
||||
return response('', 404);
|
||||
}
|
||||
|
||||
return null;
|
||||
});
|
||||
})->create();
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
<?php
|
||||
|
||||
use Illuminate\Support\Facades\Log;
|
||||
use Livewire\Mechanisms\HandleRequests\EndpointResolver;
|
||||
|
||||
it('returns 404 for stale livewire css module urls instead of 500', function () {
|
||||
@@ -10,6 +11,19 @@ it('returns 404 for stale livewire css module urls instead of 500', function ()
|
||||
$response->assertNotFound();
|
||||
});
|
||||
|
||||
it('does not report stale livewire css module exceptions to the logs', function () {
|
||||
Log::spy();
|
||||
|
||||
$prefix = EndpointResolver::prefix();
|
||||
|
||||
$this->get($prefix.'/css/meetups--landingpage.css?v=1502173559')
|
||||
->assertNotFound();
|
||||
|
||||
Log::shouldNotHaveReceived('error');
|
||||
Log::shouldNotHaveReceived('critical');
|
||||
Log::shouldNotHaveReceived('emergency');
|
||||
});
|
||||
|
||||
it('returns 404 for stale livewire global css module urls', function () {
|
||||
$prefix = EndpointResolver::prefix();
|
||||
|
||||
|
||||
Reference in New Issue
Block a user